-
Notifications
You must be signed in to change notification settings - Fork 20
Use qcom-ptool for RB1 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Loïc Minier <[email protected]>
Allows skipping QCM6490 when working on other platforms. Signed-off-by: Loïc Minier <[email protected]>
Test jobs for commit 79f9ea3 |
| -not -name 'wipe*.xml' \ | ||
| -not -name 'zeros_*' \ | ||
| \( \ | ||
| -name LICENSE \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change does not seem related to this PR/commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to this change, I was copying all files from the Linaro rescue image including the LICENSE; after this change, I'm only copying specific files with find, so I've added this other license name to the allowed list.
There are two identical bits of logic in that file now, for RB1 and QCM6490, as to allow merging them in the future; I took steps to pull them closer to each other as to eventually factor them – RB1 used to be super specific, but now there's hope to have common logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i see. that still seems to be an example of a commit that does 2 things. That line here aligns the 6490 with 2210 after you removed the dependency on the linaro rescue image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this is getting a bit convoluted in here!
|
Test flashed + booted on RB1 manually |
Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
Test jobs for commit 584beaa |
Improve flash recipe, align QCM6490 and RB1, then use qcom-ptool for RB1: