Skip to content

Conversation

@lool
Copy link
Contributor

@lool lool commented May 26, 2025

Improve flash recipe, align QCM6490 and RB1, then use qcom-ptool for RB1:

  • debos: flash: Use build_rb1 in conditions
  • debos: flash: Add build_qcm6490 conditional
  • debos: flash: Use qcom-ptool for RB1

lool added 2 commits May 26, 2025 16:48
Allows skipping QCM6490 when working on other platforms.

Signed-off-by: Loïc Minier <[email protected]>
@github-actions
Copy link

Test Results

 1 files  ±0   2 suites  ±0   3m 0s ⏱️ ±0s
15 tests ±0  15 ✅ ±0  0 💤 ±0  0 ❌ ±0 
19 runs  ±0  19 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 79f9ea3. ± Comparison against base commit d58f3a8.

@github-actions
Copy link

Test jobs for commit 79f9ea3

-not -name 'wipe*.xml' \
-not -name 'zeros_*' \
\( \
-name LICENSE \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change does not seem related to this PR/commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to this change, I was copying all files from the Linaro rescue image including the LICENSE; after this change, I'm only copying specific files with find, so I've added this other license name to the allowed list.

There are two identical bits of logic in that file now, for RB1 and QCM6490, as to allow merging them in the future; I took steps to pull them closer to each other as to eventually factor them – RB1 used to be super specific, but now there's hope to have common logic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i see. that still seems to be an example of a commit that does 2 things. That line here aligns the 6490 with 2210 after you removed the dependency on the linaro rescue image.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is getting a bit convoluted in here!

@lool
Copy link
Contributor Author

lool commented May 27, 2025

Test flashed + booted on RB1 manually

@lool lool force-pushed the rb1-use-ptool branch from 79f9ea3 to 584beaa Compare May 27, 2025 12:21
@lool lool merged commit c4836d4 into qualcomm-linux:main May 27, 2025
8 checks passed
@github-actions
Copy link

Test jobs for commit 584beaa

@lool lool deleted the rb1-use-ptool branch May 28, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants